Enable ending animation in `RequireTwoFactorAuthenticationModal` #50790

zfurtak · 2024-10-15T10:14:59Z

Details

As a part of improving UX reliability I fixed animation of RequireTwoFactorAuthenticationModal on native app, as before it was sliding up and later just disappearing.

This is how it acted before

before.mov

This is after the change, but here I had the impression that it's sliding down much faster than sliding up

after.mov

So here is a version with animationOutTiming={500}

after_500.mov

Fixed Issues

$ #49354
PROPOSAL:

Tests

Have account without two factor authentication
Create a workspace and enable Accounting
Go to Accounting and tap connect to Xero
2FA modal should be shown, modal should slide in and out smoothly

Verify that no errors appear in the JS console

Offline tests

QA Steps

Have account without two factor authentication
Create a workspace and enable Accounting
Go to Accounting and tap connect to Xero
2FA modal should be shown, modal should slide in and out smoothly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

after.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

BartoszGrajdek

LGTM! Maybe tag design team to confirm it with them?

zfurtak · 2024-10-17T09:24:54Z

Sure!
@shawnborton what do you think about the change? 😊

shawnborton · 2024-10-17T09:31:38Z

Why does it do this behavior in the first place though? It seems like it just goes away automatically? cc @Expensify/design as well

zfurtak · 2024-10-17T09:44:30Z

Because of the implementation
Instead of changing visibility of the modal, the component is implemented conditionally, so after change of the value it just disappear ✨

shawnborton · 2024-10-17T09:46:37Z

Hmm I am not following. Why would we show this modal and then immediately close it?

zfurtak · 2024-10-17T09:50:36Z

I think the fact that it is closing immediately instead of sliding down, is a bug

shawnborton · 2024-10-17T09:53:21Z

Regardless if it closes immediately or slides down, why do we show the modal quickly and then unshow it right away? The user doesn't even get a chance to read it or interact with it. That feels like the real bug to me.

zfurtak · 2024-10-17T09:55:31Z

Ah, sorry for the confusion, the modal is shown for as long ad the user doesn't close it, I just clicked fast to show how inconsistent the in and out animations are 😊

shawnborton · 2024-10-17T10:01:25Z

Ahhhh okay, that makes more sense. Then yeah, the slide down animation feels nicer.

zfurtak · 2024-10-17T10:36:30Z

And which option is better the default one (after.mov) or with 500ms animation (after_500.mov)?

shawnborton · 2024-10-17T12:25:59Z

Yeah I like the second video you have that adds a little bit of timing.

melvin-bot · 2024-10-17T12:29:48Z

@shawnborton @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dannymcclain · 2024-10-17T13:44:38Z

Yeah I like the second video you have that adds a little bit of timing.

Same!

situchan · 2024-10-17T19:34:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

mchrome.mp4

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

situchan · 2024-10-17T19:33:27Z

src/components/RequireTwoFactorAuthenticationModal.tsx

@@ -47,6 +47,7 @@ function RequireTwoFactorAuthenticationModal({onCancel = () => {}, description,
                    type={shouldUseNarrowLayout ? CONST.MODAL.MODAL_TYPE.BOTTOM_DOCKED : CONST.MODAL.MODAL_TYPE.CONFIRM}
                    innerContainerStyle={{...styles.pb5, ...styles.pt3, ...styles.boxShadowNone}}
                    shouldEnableNewFocusManagement={shouldEnableNewFocusManagement}
+                    animationOutTiming={500}


500 is new value, specific to this modal. If this looks much smoother than before, should this be applied to all modals for consistency?
I think we can leave as is for now so suggest to remove this line

In general, we're now improving user experience related to modal in this issue. This is just a part of bigger change 😊
Here in this PR I was just fixing a small bug that I spotted, while analysing all modals in the app. But I thought it would better look with the longer slide out animation, that's why I asked the design team 📞
Soon all modals will be more consistent in case of animations.

src/components/ConnectToXeroFlow/index.native.tsx

dubielzyk-expensify · 2024-10-17T22:35:41Z

Agree that the second video is better 👍

zfurtak · 2024-10-21T10:04:09Z

@situchan could you take a look again? 😊

mountiny

Love it, thanks @zfurtak! Keep it up with the great animation improvements

melvin-bot · 2024-10-22T04:03:05Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2024-10-22T04:07:13Z

This is not Emergency the checks were passing, there seems to be some bug with the emergency logic now

OSBotify · 2024-10-22T04:13:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-22T04:48:27Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

IuliiaHerets · 2024-10-22T13:50:10Z

This PR is failing for mWeb/Safari and mWeb/Chrome because of issue #51254

zfurtak · 2024-10-22T14:29:34Z

I'm looking into it 🫡

zfurtak · 2024-10-22T17:46:41Z

After some analysis and testing, I believe that the issue is not caused by this PR. The bug was there before and may be more visible now.

github-actions · 2024-10-23T16:25:54Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

zfurtak added 2 commits October 15, 2024 11:13

Enable animation out

b407136

Changed animationOutTiming

bca11fb

BartoszGrajdek approved these changes Oct 16, 2024

View reviewed changes

zfurtak marked this pull request as ready for review October 17, 2024 12:29

zfurtak requested a review from a team as a code owner October 17, 2024 12:29

melvin-bot bot requested review from shawnborton and situchan and removed request for a team October 17, 2024 12:29

situchan reviewed Oct 17, 2024

View reviewed changes

Adjusted to review

194adfa

situchan approved these changes Oct 21, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny October 21, 2024 21:18

mountiny assigned zfurtak Oct 22, 2024

mountiny approved these changes Oct 22, 2024

View reviewed changes

mountiny merged commit e5e0da2 into Expensify:main Oct 22, 2024
17 checks passed

melvin-bot bot added the Emergency label Oct 22, 2024

mountiny removed the Emergency label Oct 22, 2024

github-actions bot mentioned this pull request Oct 22, 2024

Deploy Checklist: New Expensify 2024-10-22 #51219

Closed

74 tasks

IuliiaHerets mentioned this pull request Oct 22, 2024

[$250] mWeb - Xero - 2FA animation slides in and out slowly #51254

Closed

8 tasks

melvin-bot bot mentioned this pull request Oct 23, 2024

[UX Reliability] Improve the bottom modal animations quality and reliability on native and mWeb platforms #49354

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable ending animation in `RequireTwoFactorAuthenticationModal` #50790

Enable ending animation in `RequireTwoFactorAuthenticationModal` #50790

zfurtak commented Oct 15, 2024 •

edited

Loading

BartoszGrajdek left a comment

zfurtak commented Oct 17, 2024

shawnborton commented Oct 17, 2024

zfurtak commented Oct 17, 2024

shawnborton commented Oct 17, 2024

zfurtak commented Oct 17, 2024

shawnborton commented Oct 17, 2024

zfurtak commented Oct 17, 2024

shawnborton commented Oct 17, 2024

zfurtak commented Oct 17, 2024

shawnborton commented Oct 17, 2024

melvin-bot bot commented Oct 17, 2024

dannymcclain commented Oct 17, 2024

situchan commented Oct 17, 2024 •

edited

Loading

situchan Oct 17, 2024

zfurtak Oct 18, 2024

dubielzyk-expensify commented Oct 17, 2024

zfurtak commented Oct 21, 2024

mountiny left a comment

melvin-bot bot commented Oct 22, 2024

mountiny commented Oct 22, 2024

OSBotify commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

IuliiaHerets commented Oct 22, 2024

zfurtak commented Oct 22, 2024

zfurtak commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

Enable ending animation in RequireTwoFactorAuthenticationModal #50790

Enable ending animation in RequireTwoFactorAuthenticationModal #50790

Conversation

zfurtak commented Oct 15, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

BartoszGrajdek left a comment

Choose a reason for hiding this comment

zfurtak commented Oct 17, 2024

shawnborton commented Oct 17, 2024

zfurtak commented Oct 17, 2024

shawnborton commented Oct 17, 2024

zfurtak commented Oct 17, 2024

shawnborton commented Oct 17, 2024

zfurtak commented Oct 17, 2024

shawnborton commented Oct 17, 2024

zfurtak commented Oct 17, 2024

shawnborton commented Oct 17, 2024

melvin-bot bot commented Oct 17, 2024

dannymcclain commented Oct 17, 2024

situchan commented Oct 17, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

situchan Oct 17, 2024

Choose a reason for hiding this comment

zfurtak Oct 18, 2024

Choose a reason for hiding this comment

dubielzyk-expensify commented Oct 17, 2024

zfurtak commented Oct 21, 2024

mountiny left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 22, 2024

mountiny commented Oct 22, 2024

OSBotify commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

IuliiaHerets commented Oct 22, 2024

zfurtak commented Oct 22, 2024

zfurtak commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

Enable ending animation in `RequireTwoFactorAuthenticationModal` #50790

Enable ending animation in `RequireTwoFactorAuthenticationModal` #50790

zfurtak commented Oct 15, 2024 •

edited

Loading

situchan commented Oct 17, 2024 •

edited

Loading